Comments on: A NAT-PMP client library for Python

By: NatMap 0.0 « Stranger At Large

NatMap 0.0 « Stranger At Large — Thu, 21 May 2009 13:42:25 +0000

[...] But it requires a rather large SOAP library. For NAT-PMP there’s a few hacks (notably this) around, but nothing really [...]

By: yiming

yiming — Tue, 05 Feb 2008 11:45:00 +0000

Hi roee shlomo,

Thanks for the regex. I’ve integrated it.

By: Roee Shlomo

Roee Shlomo — Tue, 05 Feb 2008 11:12:00 +0000

Hi,

I noticed the get_gateway_addr for nt systems is still TODO.
I think the following pattern would work, the rest of the code should be exactly the same as the posix code. it works fine here.

>pattern = re.compile(".*?Default Gateway:[ ]+(.*?)\n")

By: yiming

yiming — Tue, 05 Feb 2008 01:10:00 +0000

Hi anon,

Thanks for the suggest/bug report. The mutex was left over from when I tried to do a simple thread-safe queue for requests, as per the spec. I decided to leave it for 0.0.2, and forgot to remove the half-baked attempt.

I've removed it for now until the exception raising and handling code gets cleaned up a bit.

By: Anonymous

Anonymous — Mon, 04 Feb 2008 21:45:00 +0000

One suggestion:
put the send_request_with_retry calls inside a try-finally block.
>try:
> addr_response = send_request_with_retry(...)
>finally:
> request_mutex.unlock()

By: Anonymous

Anonymous — Mon, 04 Feb 2008 18:54:00 +0000

Many thanks!

I really needed this one
I’m sure it would be useful for many python applications.
Thanks again.